Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margin bug at bottom of lists (Cherry-pick of #218) #242

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

Fixes #201. As described there, we had two issues:

  1. For ordered lists, there was no margin underneath it.
  2. For unordered lists, we were adding a margin inside nested list elements, which was not intended. We only want to add a margin at the very end of the outer-most list.

This is fixed by only applying the margin to the elements article.pytorch-article ol and article.pytorch-article ul, which only apply to the outer most list.

Before:

Screenshot 2023-03-17 at 11 29 35 AM

--

After:

Screenshot 2023-03-17 at 11 28 30 AM

--


Fixes Qiskit#201. As described there, we had two issues:

1. For ordered lists, there was no margin underneath it. 
2. For unordered lists, we were adding a margin inside nested list
elements, which was not intended. We only want to add a margin at the
very end of the outer-most list.

This is fixed by only applying the margin to the elements
`article.pytorch-article ol` and `article.pytorch-article ul`, which
only apply to the outer most list.

## Before:

<img width="472" alt="Screenshot 2023-03-17 at 11 29 35 AM"
src="https://user-images.githubusercontent.com/23662430/225805307-76c22599-35b0-42a3-a57d-4db8cfc77708.png">

--



![](https://user-images.githubusercontent.com/14852634/224808178-ae18639c-503c-4224-b1db-98a23d33a94a.png)

## After:

<img width="474" alt="Screenshot 2023-03-17 at 11 28 30 AM"
src="https://user-images.githubusercontent.com/23662430/225805322-53ed87a4-c70a-4254-808f-3cd9addf46fe.png">

--


![](https://user-images.githubusercontent.com/14852634/224808410-76e98eba-f90a-4859-82a1-5c9fcf27143d.png)

---------

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
@Eric-Arellano Eric-Arellano merged commit 9377bd0 into Qiskit:1.11 Apr 4, 2023
@Eric-Arellano Eric-Arellano deleted the cp-margin-bug branch April 4, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants