Fixed right sidebar bug and make sticky (#251) #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR: - fixes Qiskit#210 - fixed another bug I found in the process where the breadcrumb component cuts of the main text and right sidebar when it contains long text - made the right sidebar sticky on scroll bug 210 fixed when language dropdown not included: <img width="1499" alt="Screenshot 2023-04-06 at 4 16 16 PM" src="https://user-images.githubusercontent.com/23662430/230485452-94d3d823-326e-413e-8d16-ba2dc5a89e4e.png"> no regression when language dropdown enabled: <img width="1464" alt="Screenshot 2023-04-06 at 3 42 51 PM" src="https://user-images.githubusercontent.com/23662430/230484892-b75874f4-8740-4894-8328-a9a29aff8706.png"> all content visible with a long breadcrumb: <img width="1501" alt="Screenshot 2023-04-06 at 3 22 36 PM" src="https://user-images.githubusercontent.com/23662430/230484891-48ad3a3a-aa51-413a-ac44-839d70293980.png"> sidebar sticky on scroll: https://user-images.githubusercontent.com/23662430/230484882-5fdd8768-92cb-4b5d-8c5a-0175f326991f.mov
Eric-Arellano
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
bug 210 fixed when language dropdown not included:
no regression when language dropdown enabled:
all content visible with a long breadcrumb:
sidebar sticky on scroll:
Screen.Recording.2023-04-06.at.3.40.45.PM.mov