Fix regression of code links being blue (Cherry-pick of #336) #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes Qiskit#335. I git bisected this to Qiskit#292. Before, we weren't actually fully running `theme.js` because JavaScript errors prevented the file from fully executing. @coruscating identified that before the regression, the HTML elements did not have the class `.has-code`, but after they did. I suspect `theme.js` is responsible for that (but I couldn't figure out how!) Either way, these rules about `.has-code` are bad. We should not be setting links to be blue.
Merged
Eric-Arellano
added a commit
that referenced
this pull request
May 22, 2023
Tested on Experiments and Terra. Only known issue was fixed already: #337.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #335.
I git bisected this to
#292. Before, we weren't actually fully running
theme.jsbecause JavaScript errors prevented the file from fully executing. @coruscating identified that before the regression, the HTML elements did not have the class.has-code, but after they did. I suspecttheme.jsis responsible for that (but I couldn't figure out how!)Either way, these rules about
.has-codeare bad. We should not be setting links to be blue.