Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Qiskit top nav bar to use ecosystem links #375

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

Revendors the top nav bar with Qiskit/web-components#229.

Copy link
Collaborator Author

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to review here. The change is auto-generated, as described here:

To update the top nav bar web component:
1. In https://github.com/Qiskit/web-components, run `npm install` then `npm run build`.
2. There should be a file created at the root of the web components repository called `experimental-bundled-ui-shell.js`. Copy its contents into these files in this theme repository:
1. `qiskit_sphinx_theme/pytorch_base/static/js/web-components/top-nav-bar.js`
2. `qiskit_sphinx_theme/furo/base/static/js/web-components/top-nav-bar.js`
3. Build the example docs with `tox -e docs` and `THEME=_qiskit_furo tox -e docs` to ensure everything works.

The docs look good when I tried them locally.

--

We could decide to cherry-pick this and release 1.12.1, but I don't think it's necessary. The old docs will always redirect to the ecosystem, so there is little urgency. I'm hoping to release 1.13 at the end of June.

Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked out your branch and had a look at the links, they seem to be ok as far as I can tell 🚀

@Eric-Arellano Eric-Arellano merged commit b8617d9 into Qiskit:main Jun 13, 2023
5 checks passed
@Eric-Arellano Eric-Arellano deleted the update-top-nav branch June 13, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants