Fix Furo's responsiveness for qiskit-card and qiskit-call-to-action-item
#447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankharkins
approved these changes
Jul 3, 2023
Comment on lines
+77
to
+83
| @media (max-width: 67em) { | ||
| width: 15rem; | ||
| } | ||
|
|
||
| @media (max-width: 40em) { | ||
| width: 10rem; | ||
| } |
There was a problem hiding this comment.
Looks good for now, I wonder if a different arrangement would look nicer at small screen sizes. For example, here's some cards from qiskit.org/events at wide and narrow:
There was a problem hiding this comment.
I like this a lot more. Thank you! Thoughts if it's a Furo 1.0 blocker? Or fine to go out in late July / early August with the next theme release?
If it's fine to wait, I'll open an issue to track this.
There was a problem hiding this comment.
No I don't think it should block anything, just a nice-to-have for the future :)
…fix-responsiveness-directives
Eric-Arellano
added a commit
to Eric-Arellano/qiskit_sphinx_theme
that referenced
this pull request
Jul 5, 2023
…n-item` (Qiskit#447) These rendered really badly when using Furo on the Terra docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rendered really badly when using Furo on the Terra docs.