Allow hiding Qiskit top nav bar in Furo #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
added a commit
to Eric-Arellano/qiskit_sphinx_theme
that referenced
this pull request
Jul 7, 2023
Unblocks Qiskit#465. This allows turning off the top nav bar with simply this CSS: ```css body { --qiskit-top-nav-bar-height: 0; } qiskit-ui-shell { display: none; } ``` We'll correctly turn off all the height adjustments we had to make in `_top-nav-bar.scss` and `qiskit-sphinx-theme.js` with that config. -- We'll use this CSS code in the Ecosystem theme, and we know Rustworkx will also want to use this code manually when adopting qiskit-sphinx-theme 1.13.
Eric-Arellano
added a commit
that referenced
this pull request
Jul 7, 2023
Unblocks #465. This allows turning off the top nav bar with simply this CSS: ```css body { --qiskit-top-nav-bar-height: 0; } qiskit-ui-shell { display: none; } ``` We'll correctly turn off all the height adjustments we had to make in `_top-nav-bar.scss` and `qiskit-sphinx-theme.js` with that config. -- We'll use this CSS code in the Ecosystem theme, and we know Rustworkx will also want to use this code manually when adopting qiskit-sphinx-theme 1.13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #465.
This allows turning off the top nav bar with simply this CSS:
We'll correctly turn off all the height adjustments we had to make in
_top-nav-bar.scssandqiskit-sphinx-theme.jswith that config.--
We'll use this CSS code in the Ecosystem theme, and we know Rustworkx will also want to use this code manually when adopting qiskit-sphinx-theme 1.13.