Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style deprecations for qiskit and qiskit-ecosystem themes #558

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Aug 23, 2023

Closes #528. They use the same style as a warning admonition so that we're consistent with Carbon.

Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 thanks Eric!

@Eric-Arellano Eric-Arellano merged commit 551c223 into Qiskit:main Aug 23, 2023
5 checks passed
@Eric-Arellano Eric-Arellano deleted the deprecations branch August 23, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate notice does not stand up in the documentation
2 participants