Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purge transparent rectangle #612

Merged
merged 4 commits into from
Jun 19, 2024
Merged

purge transparent rectangle #612

merged 4 commits into from
Jun 19, 2024

Conversation

kevinsung
Copy link
Collaborator

@kevinsung kevinsung commented Jun 19, 2024 •
edited
Loading

and also rewrite one instance of roundabout CSS class usage (see last commit)

@kevinsung kevinsung marked this pull request as ready for review June 19, 2024 15:59
Eric-Arellano
Eric-Arellano approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If you're willing, it would be helpful to add a comment to the top of the file about how these SVGs were generated & how we made some edits like removing _Transparent_Rectangle_. The idea is to help future people who need to add a new icon

@kevinsung kevinsung enabled auto-merge (squash) June 19, 2024 17:48
@kevinsung kevinsung merged commit 1ae871e into Qiskit:main Jun 19, 2024
3 checks passed
@kevinsung kevinsung deleted the purge-transparent-rectangle branch June 19, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinsung @Eric-Arellano