Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reverse direction serialization #840

Open
mtreinish opened this issue Mar 20, 2023 · 5 comments
Open

Add reverse direction serialization #840

mtreinish opened this issue Mar 20, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mtreinish
Copy link
Member

What is the expected enhancement?

Right now rustworkx has a json node link serializer (https://qiskit.org/documentation/rustworkx/apiref/rustworkx.node_link_json.html#rustworkx.node_link_json) and a graphml deserializer (https://qiskit.org/documentation/rustworkx/apiref/rustworkx.read_graphml.html#rustworkx.read_graphml) but no reverse path functions. We should add a node link json deserializer (to read node link json into a graph object) and a graphml serializer (to generate a graphml payload from a graph object) so that you can round-trip a graph over a serialization format.
@mtreinish mtreinish added enhancement New feature or request good first issue Good for newcomers labels Mar 20, 2023
@mtreinish mtreinish added this to the 0.13.0 milestone Mar 20, 2023
@mtreinish mtreinish removed this from the 0.13.0 milestone May 10, 2023
@mtreinish
Copy link
Member Author

Also the dot file from graph.to_dot() we should have a from_dot() too https://qiskit.org/documentation/retworkx/dev/apiref/rustworkx.PyGraph.to_dot.html

@AngeloDanducci
Copy link

Feel free to assign this to me @mtreinish have some work in progress on this.

@mtreinish
Copy link
Member Author

Sure thing, I've assigned you to this issue

@AngeloDanducci
Copy link

Had some other priorities pop up, returning this now 👍

@mtreinish
Copy link
Member Author

Hey, @AngeloDanducci I was wondering how this was going and if you needed any help.

mtreinish added a commit to mtreinish/retworkx that referenced this issue Feb 16, 2024
@mtreinish
Add functions to parse node link JSON
8ff74f5 
This commit adds the missing functionality to parse node link json and
generate rustworkx graph objects from it. This adds two new functions
parse_node_link_json_str() to parse a node link json string and
parse_node_link_json_file() to parse a node link json file from a path.

Partial Qiskit#840
@mtreinish mtreinish mentioned this issue Feb 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtreinish @AngeloDanducci