Promote arm64 macOS to tier 1 #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github recently added a new macOS runner that is using the m1 CPU that is usable for open source projects. [1] Previously rustworkx had support for arm64 macOS at tier 4 because we were only able to cross compile for the platform and not test the binaries. Now that we can run CI jobs on the platform we're able to run both unit tests and test our binaries on release. This commit adds a new set of test jobs and wheel builds that use the macos-14 runner that mirrors the existing x86_64 macOS jobs we have. This brings arm64 macOS to the same support level as arm64. [1] https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
The setup-python action on macos-14 only has python 3.12 installers for specific patch versions. This commit specifies that we use 3.12.0 as this lets us start using stestr again to improve test throughput. Using 3.12.1 is blocked as there was a breaking api change made to unittest in that Python release which is causing skip tests to be reported as errors.
|
This failed for Python 3.8 and 3.9 because the |
mtreinish
force-pushed
the
m1-tier-one
branch
from
1fba906
to
c76c208
Compare
mtreinish
force-pushed
the
m1-tier-one
branch
from
c76c208
to
2852a90
Compare
Pull Request Test Coverage Report for Build 8003871005Details
💛 - Coveralls |
IvanIsCoding
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
LGTM. I just added a comment related to stestr and Python 3.12.
After #1064 is merged I wonder if we should have a Linux job cross-compiling the wheels for Linux, Windows and macOS universal because it would really save us time with all these runners. Most of the testing time is spent building the crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github recently added a new macOS runner that is using the m1 CPU that is usable for open source projects. [1] Previously rustworkx had support for arm64 macOS at tier 4 because we were only able to cross compile for the platform and not test the binaries. Now that we can run CI jobs on the platform we're able to run both unit tests and test our binaries on release. This commit adds a new set of test jobs and wheel builds that use the macos-14 runner that mirrors the existing x86_64 macOS jobs we have. This brings arm64 macOS to the same support level as arm64.
[1] https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/