Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move collect_bicolor_runs() to rustworkx-core #1186

Merged
merged 18 commits into from
Jun 10, 2024
Merged

Move collect_bicolor_runs() to rustworkx-core #1186

merged 18 commits into from
Jun 10, 2024

Commits on May 8, 2024

  1. Attempt with graph.node_weight

    @ElePT
    ElePT committed May 8, 2024
    Configuration menu
    Copy the full SHA
    55f3b1a View commit details
    Browse the repository at this point in the history

  2. Progress until hitting error.

    @ElePT
    ElePT committed May 8, 2024
    Configuration menu
    Copy the full SHA
    59f27c9 View commit details
    Browse the repository at this point in the history

  3. Return node ids instead of node weights. Code compiles!!!

    @ElePT
    ElePT committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b57b9d7 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Merge branch 'main' of https://github.com/Qiskit/rustworkx into colle… 

    …ct-bicolor
    @ElePT
    ElePT committed May 27, 2024
    Configuration menu
    Copy the full SHA
    bafd97f View commit details
    Browse the repository at this point in the history

  2. Move collect_bicolor_runs.rs to rustworkx-core/src/dag_algo.rs

    @ElePT
    ElePT committed May 27, 2024
    Configuration menu
    Copy the full SHA
    d6a2894 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Add pyo3 wrapper for core collect_bicolor_runs, modify test, small fi… 

    …xes.
    @ElePT
    ElePT committed May 29, 2024
    Configuration menu
    Copy the full SHA
    22821fd View commit details
    Browse the repository at this point in the history

  2. Fix DagHasCycle error to match previous type

    @ElePT
    ElePT committed May 29, 2024
    Configuration menu
    Copy the full SHA
    b77b269 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Clean up unused parameters and functions, simplify error handling, ad… 

    …d unit tests and reno.
    @ElePT
    ElePT committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c98b279 View commit details
    Browse the repository at this point in the history

  2. Use PyResult, fix comments

    @ElePT
    ElePT committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    842e5bf View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Apply feedback from Matt's review, make tests make more sense.

    @ElePT
    ElePT committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    cd5b752 View commit details
    Browse the repository at this point in the history

  2. Add suggestion from Matt's code review 

    Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
    @ElePT @mtreinish
    ElePT and mtreinish committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f60cf6b View commit details
    Browse the repository at this point in the history

  3. Remove stray print 

    Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
    @ElePT @mtreinish
    ElePT and mtreinish committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    23ba36b View commit details
    Browse the repository at this point in the history

  4. Change callbacks to take ids instead of weights, rename some variable… 

    …s in tests for clarity.
    @ElePT
    ElePT committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c256e27 View commit details
    Browse the repository at this point in the history

  5. Fix test

    @ElePT
    ElePT committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0222319 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
    @ElePT @mtreinish
    ElePT and mtreinish committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    030eee7 View commit details
    Browse the repository at this point in the history

  2. Get rid of unused trait

    @ElePT
    ElePT committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9c262e0 View commit details
    Browse the repository at this point in the history

  3. Fix fmt

    @ElePT
    ElePT committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    7c0f7bc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into collect-bicolor

    @mtreinish
    mtreinish committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    7edc383 View commit details
    Browse the repository at this point in the history