Add G(n,m) random graph generator #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoAllabbad
force-pushed
the
random-gnm
branch
from
b2a4b46
to
8389787
Compare
This adds two G(n,m) graph generators, one directed and one undirected. The generated graph will be a random graph out of all the possible graphs that are n nodes and m edges with max n*(n-1) edges for directed graphs and n*(n-1)/2 for undirected graphs, avoiding self-loops and multigraphs. The run time is O(n+m) Fixes Qiskit#174
Pull Request Test Coverage Report for Build 315839295
💛 - Coveralls |
mtreinish
changed the title
mtreinish
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
This LGTM, thanks for taking on this enhancement.
Before we merge this I think we should do the !.is_some() -> is_none() change. The other comments inline are just a couple of idle thoughts I had, but not worth blocking over (or necessarily even doing in the case of usize vs isize for parameters)
Apply suggestions from code review Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two G(n,m) graph generators, one directed and one undirected.
The generated graph will be a random graph out of all the possible
graphs that are n nodes and m edges with max n*(n-1) edges for directed
graphs and n*(n-1)/2 for undirected graphs, avoiding self-loops and
multigraphs. The run time is O(n+m)
Fixes #174