Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary of the rustworkx benchmarks to the documentation #736

Merged
merged 7 commits into from
Nov 21, 2022

Conversation

cometta
Copy link
Contributor

@cometta cometta commented Nov 9, 2022

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. I have three minor comments regarding the images:

  • we might need to increase the axis on the Time to create a weighted directed graph
  • we need to update the captions to say rustworkx not retworkx
  • Because we are on the web I think saving the image as an .svg might be better than using .png

@coveralls
Copy link

coveralls commented Nov 9, 2022

Pull Request Test Coverage Report for Build 3510505910

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 96.924%

Totals Coverage Status
Change from base Build 3503349955: -0.05%
Covered Lines: 13328
Relevant Lines: 13751

💛 - Coveralls

@cometta
Copy link
Contributor Author

cometta commented Nov 9, 2022

I made changes according to your comments. Let me know if anything else pending

@IvanIsCoding
Copy link
Collaborator

I made changes according to your comments. Let me know if anything else pending

Can you run pip show <package> for each graph package and post the configuration of your system (e.g. Ubuntu 22.04 with AMD Ryzen XYZ and 128Gb of RAM) on the comments for this PR?

I will take over and add these details and the citations for where we grabbed the datasets, then we should be good to go

@cometta
Copy link
Contributor Author

cometta commented Nov 10, 2022

build from main branch https://git.skewed.de/count0/graph-tool.git, Debian GNU/Linux 11 (bullseye), Intel i9-9900K 32Gb of ram

Name: numpy
Version: 1.23.4
Summary: NumPy is the fundamental package for array computing with Python.
Home-page: https://www.numpy.org
Author: Travis E. Oliphant et al.
Author-email:
License: BSD
Location: /usr/local/lib/python3.11/site-packages
Requires:
Required-by: matplotlib, pandas, scipy, seaborn, tikzplotlib

Name: scipy
Version: 1.9.3
Summary: Fundamental algorithms for scientific computing in Python
Home-page: https://scipy.org/
Author:
Author-email:
License: Copyright (c) 2001-2002 Enthought, Inc. 2003-2022, SciPy Developers.
All rights reserved.

Name: matplotlib
Version: 3.4.3
Summary: Python plotting package
Home-page: https://matplotlib.org
Author: John D. Hunter, Michael Droettboom
Author-email: matplotlib-users@python.org
License: PSF
Location: /usr/local/lib/python3.11/site-packages
Requires: cycler, kiwisolver, numpy, pillow, pyparsing, python-dateutil
Required-by: seaborn, tikzplotlib

Name: virtualenv
Version: 20.16.6
Summary: Virtual Python Environment builder
Home-page: https://virtualenv.pypa.io/
Author: Bernat Gabor
Author-email: gaborjbernat@gmail.com
License: MIT
Location: /usr/local/lib/python3.11/site-packages
Requires: distlib, filelock, platformdirs
Required-by:

Name: seaborn
Version: 0.12.1
Summary: Statistical data visualization
Home-page:
Author:
Author-email: Michael Waskom <mwaskom@gmail.com>
License:
Location: /usr/local/lib/python3.11/site-packages
Requires: matplotlib, numpy, pandas
Required-by:

Name: tikzplotlib
Version: 0.10.1
Summary: Convert matplotlib figures into TikZ/PGFPlots
Home-page:
Author:
Author-email: Nico Schlömer <nico.schloemer@gmail.com>
License:
Location: /usr/local/lib/python3.11/site-packages
Requires: matplotlib, numpy, Pillow, webcolors
Required-by:

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Nov 21, 2022
@mergify mergify bot merged commit 633c40b into Qiskit:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants