Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Matplotlib warning when building docs #820

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix Matplotlib warning when building docs #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/tutorial/betweenness_centrality.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ Alternatively, you can use :func:`~rustworkx.visualization.graphviz_draw`:
graph[node] = btw

# Leverage matplotlib for color map
colormap = matplotlib.cm.get_cmap("magma")
colormap = matplotlib.colormaps["magma"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our minimum matplotlib version in the optional extras is 3.0, Is this api available in that version? (Just don't want our docs to use an api which isn't supported on the minimum version we list as supported)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked it is there: https://matplotlib.org/3.0.0/api/pyplot_summary.html?highlight=colormaps#matplotlib.pyplot.colormaps

norm = matplotlib.colors.Normalize(
vmin=min(centrality.values()),
vmax=max(centrality.values())
Expand Down