Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump indexmap to 2.0.2, hashbrown to 0.14.1 & more #989

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

IvanIsCoding
Copy link
Collaborator

This bumps many of our dependencies, with highlights for:

More importantly, it compiles (which the previous PRs didn't for some reason)

@IvanIsCoding IvanIsCoding changed the title Bump indexmap to 2.0.2 and hashbrown to 0.14.1 & more Bump indexmap to 2.0.2, hashbrown to 0.14.1 & more Sep 30, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6360028451

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.491%

Totals Coverage Status
Change from base Build 6264508450: 0.0%
Covered Lines: 15400
Relevant Lines: 15960

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this means we can also lower our MSRV to 1.63? Either way this LGTM we can look at the MSRV question in a followup

@IvanIsCoding
Copy link
Collaborator Author

I wonder if this means we can also lower our MSRV to 1.63? Either way this LGTM we can look at the MSRV question in a followup

I tried but we can't! The workspace features introduced in #956 are 1.64+

@mtreinish mtreinish merged commit 5ab599f into Qiskit:main Oct 3, 2023
25 checks passed
@IvanIsCoding IvanIsCoding deleted the bump-indexmap branch October 3, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants