Add version management #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forchain
suggested changes
May 10, 2021
forchain
reviewed
May 10, 2021
There was a problem hiding this comment.
One suggestion
By your current implementation , we cannot view qitmeer version and the binary location by make command as Qitmeer does.
Done building.
qitmeer version 0.9.2+dev-ac02016 (Go version go1.16.3))
Run "./build/bin/qitmeer" to launch.
So if I made a build before, there is no way for me to find where the build is.
make: `build' is up to date.
lochjin
reviewed
May 10, 2021
lochjin
requested changes
May 10, 2021
dindinw
requested changes
May 10, 2021
Makefile
Outdated
|
|
||
| EXECUTABLES=$(UNIX_EXECUTABLES) $(WIN_EXECUTABLES) | ||
|
|
||
| COMPRESSED_EXECUTABLES=$(UNIX_EXECUTABLES:%=%.tar.gz) $(WIN_EXECUTABLES:%.exe=%.zip) $(WIN_EXECUTABLES:%.exe=%.cn.zip) |
There was a problem hiding this comment.
you don't need .*win.cn package, it exists for the historical reason to contain different startup scripts and useful only for the qitmeer. please cleanup the unnecessary compressed package.
Makefile
Outdated
| %.cn.zip: %.exe | ||
| @echo Build $(@).cn.zip | ||
| @echo zip $(EXECUTABLE)-$(VERSION)-$(OS)-$(ARCH) | ||
| @zip -j $(EXECUTABLE)-$(VERSION)-$(OS)-$(ARCH).cn.zip "$<" script/win/start.bat |
There was a problem hiding this comment.
should not work since the file does not exist.
| @rm -f *.zip | ||
| @rm -f *.tar.gz | ||
| @rm -f ./build/bin/qitmeer-waellt | ||
| @rm -rf ./build/release | ||
|
|
||
| webui: statik npm | ||
| cd assets/src && npm run build |
There was a problem hiding this comment.
webui is required for a clean build. please re-arrange your makefile
forchain
approved these changes
May 15, 2021
dindinw
approved these changes
May 15, 2021
lochjin
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.