Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Product.php #141

Merged
merged 4 commits into from
Oct 30, 2020
Merged

Update Product.php #141

merged 4 commits into from
Oct 30, 2020

Conversation

wdammak
Copy link
Contributor

@wdammak wdammak commented Sep 29, 2020

Fix PHP7.4

Copy link
Contributor

@shreesh-webkul shreesh-webkul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wdammak
Please remove Null Coalescing Operator as it is not supported below PHP 7.

also, Please change syntax for similar implode function calls also on line no L3464 and L3741

@wdammak
Copy link
Contributor Author

wdammak commented Oct 29, 2020

@wdammak
Please remove Null Coalescing Operator as it is not supported below PHP 7.

also, Please change syntax for similar implode function calls also on line no L3464 and L3741

@shreesh-webkul done

Copy link
Contributor

@shreesh-webkul shreesh-webkul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes Accepted

@rohit053 rohit053 merged commit 8b3657e into Qloapps:develop Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants