Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: initToolbar #497

Closed
wants to merge 1 commit into from
Closed

Fix: initToolbar #497

wants to merge 1 commit into from

Conversation

wdammak
Copy link
Contributor

@wdammak wdammak commented Jan 6, 2023

No description provided.

@shreesh-webkul
Copy link
Contributor

In outsanding page, the initToolbar is overrided to hide add button in list toolbar.
This PR adds the button back which is not required as there are no forms in this page

@wdammak
Copy link
Contributor Author

wdammak commented Jan 11, 2023

So why i have this error?:
Notice on line 2643 in file \www\hotelcommerce\classes\controller\AdminController.php
[8] Undefined property: AdminOutstandingController::$toolbar_btn

@shreesh-webkul
Copy link
Contributor

We are not able to recreate the issue, please provide us with steps to recreate the issue.
Also, please provide us with the PHP version you are running.

@wdammak
Copy link
Contributor Author

wdammak commented Jan 13, 2023

php7.4.10

once I remove this line (parent::initToolbar();) I systematically have this warning
[8] Undefined property: AdminOutstandingController::$toolbar_btn

@shreesh-webkul
Copy link
Contributor

The issue is coming from the Admin controller, we are updating the controller through which this issue will be resolved.

@wdammak
Copy link
Contributor Author

wdammak commented Jan 23, 2023

thank you @shreesh-webkul

@wdammak wdammak closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants