Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore array support in Coalesce() #65

Merged
merged 4 commits into from
Jan 9, 2018

Conversation

JoshuaC215
Copy link
Collaborator

Closes #64

@JoshuaC215
Copy link
Collaborator Author

Actual coverage, for reference:

ok      github.com/qntfy/kazaam 0.011s  coverage: 93.2% of statements
ok      github.com/qntfy/kazaam/kazaam  0.009s  coverage: 54.5% of statements
ok      github.com/qntfy/kazaam/transform       0.010s  coverage: 89.9% of statements

@JoshuaC215
Copy link
Collaborator Author

Goveralls seems to only be running top level tests and ignoring the ones in transform/

@JoshuaC215
Copy link
Collaborator Author

@chilland reviewed

@JoshuaC215 JoshuaC215 merged commit 677dc19 into qntfy:master Jan 9, 2018
@JeanMertz
Copy link

Looking at the example, this change means I can't have a source JSON key called ignore, and use the coalesce transformation on that key, is that correct?

I don't have that use-case, but I was writing some extra transformations (such as move) and was considering how to design the spec API, and took this one as an example, which got me thinking about the fact that the current API design means any extra added spec option name is another name that you can no longer use in the source JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants