fixes for issues #57 and #74 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is all in utils/StorageUtils.java: The previous code for extracting data for name storage from transaction JSON blindly assumed the data would be a string-encapsulated JSONObject. Also this code was duplicated in various places. Now this has been refactored into one place: getDataByKey() This function is more permissive in that it allows optional string encapsulation but also more restrictive in that it will return null if the data is not suitable. This should help with issues #57 and #74. Other functions in the same file have been tidied up. + version bump as this has been blocking many users from using client (unless they wipe database)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handing of the transaction mentioned in issue #57 which is also related to issue #74