Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Fix/string error reflections #113

Merged
merged 8 commits into from
Sep 27, 2020

Conversation

ReeceM
Copy link
Collaborator

@ReeceM ReeceM commented Sep 26, 2020

This is to fix the string type hint on constructor arguments.

The idea behind this is that it would return a mocked object that would give the name of the string that was passed so that end users know what it was. And not have a single repeated string all over the show.

Would close #103

@ReeceM ReeceM added WIP Work in progress V2 MailEclipse v2.x scoped Issues/PR V3 Version 3 of MailEclipse (Laravel 8) labels Sep 26, 2020
@ReeceM ReeceM changed the base branch from 2.x to master September 26, 2020 20:43
@ReeceM ReeceM changed the base branch from master to 2.x September 26, 2020 20:43
@ReeceM ReeceM linked an issue Sep 26, 2020 that may be closed by this pull request
ReeceM and others added 6 commits September 26, 2020 22:54
was return a null and want to check that later on
was return a null and want to check that later on
…vel-mail-editor into fix/string-error-reflections
@ReeceM ReeceM merged commit 4383abd into Qoraiche:2.x Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
V2 MailEclipse v2.x scoped Issues/PR V3 Version 3 of MailEclipse (Laravel 8) WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined index: string
1 participant