Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refac/improve error handling and feedback #196

Merged
merged 6 commits into from Feb 10, 2022
Merged

Refac/improve error handling and feedback #196

merged 6 commits into from Feb 10, 2022

Conversation

ReeceM
Copy link
Collaborator

@ReeceM ReeceM commented Feb 9, 2022 •
edited

Description

This is to provide a more informative error to the end user about the factory setting and lack of a factory that is defined.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ReeceM ReeceM added the v4 Laravel 9 support version label Feb 9, 2022
@ReeceM ReeceM linked an issue Feb 9, 2022 that may be closed by this pull request
[Constructor error] Fatal error when using package #1
Closed
@ReeceM ReeceM requested a review from Qoraiche February 9, 2022 21:39
Qoraiche
Qoraiche approved these changes Feb 9, 2022
View reviewed changes
Copy link
Owner

@Qoraiche Qoraiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, LGTM 🚀

@ReeceM ReeceM merged commit 76992f8 into master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qoraiche Qoraiche Qoraiche approved these changes

Assignees
No one assigned
Labels
v4 Laravel 9 support version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Constructor error] Fatal error when using package
3 participants
@ReeceM @Qoraiche @StyleCIBot