fix(onboarding): remove env variable

Qovery · Dec 22, 2022 · 1dec62f · 1dec62f
1 parent 6dc1e88
commit 1dec62f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 17 deletions.
diff --git a/apps/console/src/app/app.tsx b/apps/console/src/app/app.tsx
@@ -9,10 +9,9 @@ import { useIntercom } from 'react-use-intercom'
 import { selectUser } from '@qovery/domains/user'
 import { DarkModeEnabler, Layout } from '@qovery/pages/layout'
 import { PageLogin, PageLogoutFeature } from '@qovery/pages/login'
-import { PageOnboarding } from '@qovery/pages/onboarding'
 import { useAuth } from '@qovery/shared/auth'
 import { UserInterface } from '@qovery/shared/interfaces'
-import { LOGIN_URL, LOGOUT_URL, ONBOARDING_URL, ProtectedRoute } from '@qovery/shared/router'
+import { LOGIN_URL, LOGOUT_URL, ProtectedRoute } from '@qovery/shared/router'
 import { LoadingScreen } from '@qovery/shared/ui'
 import { useAuthInterceptor, useDocumentTitle } from '@qovery/shared/utils'
 import { environment } from '../environments/environment'
@@ -54,19 +53,6 @@ export function App() {
   useAuthInterceptor(axios, environment.api)
 
   useEffect(() => {
-    // if (process.env['NODE_ENV'] === 'production') {
-
-    // if onboarding feature flag activated we add onboarding routes to router
-    const isOnboarding = environment.onboarding === 'true'
-    if (isOnboarding) {
-      ROUTER.push({
-        path: `${ONBOARDING_URL}/*`,
-        component: <PageOnboarding />,
-        protected: true,
-        layout: false,
-      })
-    }
-
     // init logrocket
     if (process.env['NODE_ENV'] === 'production') {
       LogRocket.init(environment.logrocket)

diff --git a/apps/console/src/app/router/main.router.tsx b/apps/console/src/app/router/main.router.tsx
@@ -6,6 +6,7 @@ import { PageEnvironments } from '@qovery/pages/environments'
 import { PageApplicationLogs } from '@qovery/pages/logs/application'
 import { PageDeploymentLogs } from '@qovery/pages/logs/deployment'
 import { PageInfraLogs } from '@qovery/pages/logs/infra'
+import { PageOnboarding } from '@qovery/pages/onboarding'
 import { OverviewPage } from '@qovery/pages/overview/feature'
 import { PageServices } from '@qovery/pages/services'
 import { PageSettings } from '@qovery/pages/settings'
@@ -17,6 +18,7 @@ import {
   DEPLOYMENT_LOGS_URL,
   ENVIRONMENTS_URL,
   INFRA_LOGS_URL,
+  ONBOARDING_URL,
   ORGANIZATION_URL,
   OVERVIEW_URL,
   SERVICES_URL,
@@ -34,6 +36,12 @@ interface RouterProps {
 }
 
 export const ROUTER: RouterProps[] = [
+  {
+    path: `${ONBOARDING_URL}/*`,
+    component: <PageOnboarding />,
+    protected: true,
+    layout: false,
+  },
   {
     path: ORGANIZATION_URL(),
     component: <RedirectOverview />,

diff --git a/apps/console/src/environments/environment.prod.ts b/apps/console/src/environments/environment.prod.ts
@@ -9,5 +9,4 @@ export const environment = {
   posthog_apihost: process.env?.['NX_POSTHOG_APIHOST'] || '',
   logrocket: process.env?.['NX_LOGROCKET'] || '',
   gtm: process.env?.['NX_GTM'] || '',
-  onboarding: process.env?.['NX_ONBOARDING'] || '',
 }
diff --git a/apps/console/src/environments/environment.ts b/apps/console/src/environments/environment.ts
@@ -9,5 +9,4 @@ export const environment = {
   posthog_apihost: process.env?.['NX_POSTHOG_APIHOST'] || '',
   logrocket: process.env?.['NX_LOGROCKET'] || '',
   gtm: process.env?.['NX_GTM'] || '',
-  onboarding: process.env?.['NX_ONBOARDING'] || '',
 }