Skip to content

Commit

Permalink
fix(page-database): remove useless fetch
Browse files Browse the repository at this point in the history
  • Loading branch information
RemiBonnet committed Nov 24, 2022
1 parent ef220e5 commit 94db3e3
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions libs/pages/database/src/lib/page-database.tsx
@@ -1,10 +1,10 @@
import equal from 'fast-deep-equal'
import { Environment } from 'qovery-typescript-axios'
import { useEffect } from 'react'
import { useDispatch, useSelector } from 'react-redux'
import { Route, Routes, useParams } from 'react-router-dom'
import {
databasesLoadingStatus,
fetchDatabase,
fetchDatabaseMasterCredentials,
fetchDatabaseMetrics,
selectDatabaseById,
Expand All @@ -17,25 +17,28 @@ import { ROUTER_DATABASE } from './router/router'
import Container from './ui/container/container'

export function PageDatabase() {
useDocumentTitle('Database - Qovery')
const { databaseId = '', environmentId = '' } = useParams()
const environment = useSelector<RootState, Environment | undefined>((state) =>
selectEnvironmentById(state, environmentId)
)
const database = useSelector<RootState, DatabaseEntity | undefined>((state) => selectDatabaseById(state, databaseId))

const database = useSelector<RootState, DatabaseEntity | undefined>(
(state) => selectDatabaseById(state, databaseId),
equal
)

useDocumentTitle(`${database?.name || 'Database'} - Qovery`)

const loadingStatus = useSelector<RootState, LoadingStatus>((state) => databasesLoadingStatus(state))

const dispatch = useDispatch<AppDispatch>()

useEffect(() => {
if (databaseId && loadingStatus === 'loaded') {
if (database && databaseId && loadingStatus === 'loaded') {
database?.metrics?.loadingStatus !== 'loaded' && dispatch(fetchDatabaseMetrics({ databaseId }))
database?.credentials?.loadingStatus !== 'loaded' && dispatch(fetchDatabaseMasterCredentials({ databaseId }))
} else {
dispatch(fetchDatabase({ databaseId }))
}
}, [databaseId, loadingStatus])
}, [database && databaseId, loadingStatus])

return (
<Container database={database} environment={environment}>
Expand Down

0 comments on commit 94db3e3

Please sign in to comment.