Skip to content

Commit

Permalink
msg error
Browse files Browse the repository at this point in the history
  • Loading branch information
RemiBonnet committed Nov 24, 2022
1 parent f1993e0 commit c03b9fb
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,21 @@ export function PageSettingsResources(props: PageSettingsResourcesProps) {
name="memory"
control={control}
rules={inputSizeUnitRules(maxMemoryBySize)}
render={({ field }) => (
render={({ field, fieldState: { error } }) => (
<InputText
dataTestId="input-memory-memory"
type="number"
name={field.name}
label="Size in MB"
value={field.value}
onChange={field.onChange}
error={
error?.type === 'required'
? 'Please enter a size.'
: error?.type === 'max'
? `Maximum allowed ${field.name} is: ${maxMemoryBySize} MB.`
: undefined
}
/>
)}
/>
Expand All @@ -79,14 +86,15 @@ export function PageSettingsResources(props: PageSettingsResourcesProps) {
message: 'Please enter a number.',
},
}}
render={({ field }) => (
render={({ field, fieldState: { error } }) => (
<InputText
type="number"
name={field.name}
dataTestId="input-memory-storage"
label="Size in GB"
value={field.value}
onChange={field.onChange}
error={error?.message}
/>
)}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,21 @@ export function SettingResources(props: SettingResourcesProps) {
name="memory"
control={control}
rules={inputSizeUnitRules(maxMemoryBySize)}
render={({ field }) => (
render={({ field, fieldState: { error } }) => (
<InputText
dataTestId="input-memory-memory"
type="number"
name={field.name}
label="Size in MB"
value={field.value}
onChange={field.onChange}
error={
error?.type === 'required'
? 'Please enter a size.'
: error?.type === 'max'
? `Maximum allowed ${field.name} is: ${maxMemoryBySize} MB.`
: undefined
}
/>
)}
/>
Expand Down Expand Up @@ -116,8 +123,14 @@ export function SettingResources(props: SettingResourcesProps) {
message: 'Please enter a number.',
},
}}
render={({ field }) => (
<InputText name={field.name} label="Size in GB" value={field.value} onChange={field.onChange} />
render={({ field, fieldState: { error } }) => (
<InputText
name={field.name}
label="Size in GB"
value={field.value}
onChange={field.onChange}
error={error?.message}
/>
)}
/>
</BlockContent>
Expand Down

0 comments on commit c03b9fb

Please sign in to comment.