Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resources): change input unit to input number #389

Merged
merged 7 commits into from Nov 24, 2022

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Nov 23, 2022

What does this PR do?

> Link to the JIRA ticket

  • Remove input unit
  • Add input number for Memory
  • Clean input number for Storage (remove useless props and state)

PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - fix(resources): change input unit to input number - 2022-11-23T16:28:33Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Nov 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c03b9fb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

Copy link
Contributor

@bdebon bdebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked that every memory are in MB and every storage are in GB to respect the conventions of the API:
image

I did not notice anything wrong, you have done it carefully. I think you can merge.

@RemiBonnet RemiBonnet merged commit 2e59400 into staging Nov 24, 2022
@RemiBonnet RemiBonnet deleted the fix/input-unit-FRT-600 branch November 24, 2022 11:17
@bdebon
Copy link
Contributor

bdebon commented Nov 24, 2022

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants