Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logs): bind escape to close logs #394

Merged
merged 1 commit into from Nov 29, 2022
Merged

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

  • Bind escape touch to close Application and Deployment logs

PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(logs): bind escape to close logs - 2022-11-25T13:34:47Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Nov 25, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 18f3963. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@RemiBonnet RemiBonnet marked this pull request as ready for review November 25, 2022 13:34
@codecov-commenter
Copy link

Codecov Report

Merging #394 (18f3963) into staging (94db3e3) will decrease coverage by 4.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           staging     #394      +/-   ##
===========================================
- Coverage    57.83%   53.73%   -4.10%     
===========================================
  Files           24      298     +274     
  Lines          268     5540    +5272     
  Branches        92     1175    +1083     
===========================================
+ Hits           155     2977    +2822     
- Misses          79     2183    +2104     
- Partials        34      380     +346     
Impacted Files Coverage Δ
...organization/src/lib/slices/auth-provider.slice.ts 86.95% <0.00%> (ø)
libs/pages/overview/feature/src/lib/overview.tsx 0.00% <0.00%> (ø)
...te/page-application-post/page-application-post.tsx 60.00% <0.00%> (ø)
...ib/feature/page-settings-advanced-feature/utils.ts 66.66% <0.00%> (ø)
...ns/organization/src/lib/slices/repository.slice.ts 25.00% <0.00%> (ø)
...settings-danger-zone/page-settings-danger-zone.tsx 100.00% <0.00%> (ø)
...ui/page-settings-domains/crud-modal/crud-modal.tsx 85.71% <0.00%> (ø)
...onment-modal/ui/create-clone-environment-modal.tsx 93.75% <0.00%> (ø)
...-feature/crud-modal-feature/crud-modal-feature.tsx 48.57% <0.00%> (ø)
...-general-feature/page-settings-general-feature.tsx 84.21% <0.00%> (ø)
... and 264 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@RemiBonnet RemiBonnet merged commit c073aca into staging Nov 29, 2022
@RemiBonnet RemiBonnet deleted the feat/bind-escape-logs branch November 29, 2022 08:33
@bdebon
Copy link
Contributor

bdebon commented Nov 30, 2022

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants