Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment-logs): rows remove ANSI characters #395

Merged
merged 1 commit into from Nov 29, 2022

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

  • Remove ANSI characters for deployments logs

PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(deployment-logs): rows remove ANSI characters - 2022-11-28T10:39:03Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Nov 28, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 76af025. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@RemiBonnet RemiBonnet marked this pull request as ready for review November 28, 2022 10:39
@codecov-commenter
Copy link

Codecov Report

Merging #395 (76af025) into staging (94db3e3) will decrease coverage by 5.28%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           staging     #395      +/-   ##
===========================================
- Coverage    57.83%   52.55%   -5.29%     
===========================================
  Files           24        8      -16     
  Lines          268      137     -131     
  Branches        92       57      -35     
===========================================
- Hits           155       72      -83     
+ Misses          79       55      -24     
+ Partials        34       10      -24     
Impacted Files Coverage Δ
libs/pages/logs/deployment/src/lib/ui/row/row.tsx 96.15% <100.00%> (ø)
libs/pages/database/src/lib/page-database.tsx
...ase/src/lib/ui/instances-table/instances-table.tsx
.../pages/database/src/lib/ui/container/container.tsx
...ources-feature/page-settings-resources-feature.tsx
...-general-feature/page-settings-general-feature.tsx
...e/src/lib/ui/page-deployments/page-deployments.tsx
libs/pages/database/src/lib/router/router.tsx
...zone-feature/page-settings-danger-zone-feature.tsx
.../page-variables-feature/page-variables-feature.tsx
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@RemiBonnet RemiBonnet merged commit b0bdfd3 into staging Nov 29, 2022
@RemiBonnet RemiBonnet deleted the feat/row-deployment-logs-format branch November 29, 2022 08:33
@bdebon
Copy link
Contributor

bdebon commented Nov 30, 2022

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants