Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu-account): organizations switcher and account settings access #429

Merged
merged 8 commits into from Dec 26, 2022

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Dec 23, 2022

What does this PR do?

> Link to the JIRA ticket

  • Add organizations switcher on the left Navigation
  • Update Avatar component

Capture d’écran 2022-12-26 à 16 45 23


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@nx-cloud
Copy link

nx-cloud bot commented Dec 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9a3445d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(menu-account): organizations switcher and account settings access - 2022-12-23T16:22:48Z

Another comment will be posted when deployments are terminated

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@RemiBonnet RemiBonnet marked this pull request as ready for review December 26, 2022 15:45
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Merging #429 (9a3445d) into staging (eaa3c8a) will increase coverage by 0.02%.
The diff coverage is 56.25%.

@@             Coverage Diff             @@
##           staging     #429      +/-   ##
===========================================
+ Coverage    52.71%   52.74%   +0.02%     
===========================================
  Files          329      331       +2     
  Lines         6254     6279      +25     
  Branches      1362     1372      +10     
===========================================
+ Hits          3297     3312      +15     
- Misses        2517     2522       +5     
- Partials       440      445       +5     
Impacted Files Coverage Δ
...ibs/pages/layout/src/lib/feature/layout/layout.tsx 53.12% <0.00%> (-1.43%) ⬇️
.../pages/layout/src/lib/ui/navigation/navigation.tsx 66.66% <ø> (-2.57%) ⬇️
...-feature/page-organization-danger-zone-feature.tsx 64.28% <0.00%> (-4.95%) ⬇️
libs/shared/utils/src/lib/tools/refacto-payload.ts 45.23% <0.00%> (-1.11%) ⬇️
...es/layout/src/lib/ui/menu-account/menu-account.tsx 58.82% <58.82%> (ø)
...ture/menu-account-feature/menu-account-feature.tsx 71.42% <71.42%> (ø)
...ages/layout/src/lib/ui/layout-page/layout-page.tsx 100.00% <100.00%> (ø)
...eral-feature/page-organization-general-feature.tsx 87.50% <100.00%> (+0.54%) ⬆️
libs/pages/logs/infra/src/lib/ui/row/row.tsx 89.47% <0.00%> (-10.53%) ⬇️
...luster-buttons-actions/cluster-buttons-actions.tsx 66.66% <0.00%> (+7.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bdebon bdebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Remi ! Super cool feature ! It is so nice not having this huge breadcrumb up there. The widget works pretty well, I just have found a weird scroll jumb behavior.
If I refresh the page, I click on this switch widget, when I hove my mouse for the first time on the list, it then jumps the scroll at the level of the selected organization which is a little bit disturbing. I tried to showcase that in the video below:

CleanShot.2022-12-26.at.17.03.31.mp4

/>
<span className="w-8 h-8 rounded-sm flex items-center justify-center mr-3">
{organization.logo_url ? (
<img className="p-1" src={organization.logo_url} alt="" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the alt could be organization logo

</div>
)

const menus = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to type this variable so we can have autocomplete and checked type?

@RemiBonnet RemiBonnet merged commit 42bd7e8 into staging Dec 26, 2022
@RemiBonnet RemiBonnet deleted the feat/menu-account-FRT-620 branch December 26, 2022 17:12
@bdebon
Copy link
Contributor

bdebon commented Dec 27, 2022

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants