-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(menu-account): organizations switcher and account settings access #429
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9a3445d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
A preview environment was automatically created via Qovery. Another comment will be posted when deployments are terminated |
c8f56d9
to
f118746
Compare
62cf954
to
d3a7ec9
Compare
Codecov Report
@@ Coverage Diff @@
## staging #429 +/- ##
===========================================
+ Coverage 52.71% 52.74% +0.02%
===========================================
Files 329 331 +2
Lines 6254 6279 +25
Branches 1362 1372 +10
===========================================
+ Hits 3297 3312 +15
- Misses 2517 2522 +5
- Partials 440 445 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Remi ! Super cool feature ! It is so nice not having this huge breadcrumb up there. The widget works pretty well, I just have found a weird scroll jumb behavior.
If I refresh the page, I click on this switch widget, when I hove my mouse for the first time on the list, it then jumps the scroll at the level of the selected organization which is a little bit disturbing. I tried to showcase that in the video below:
CleanShot.2022-12-26.at.17.03.31.mp4
/> | ||
<span className="w-8 h-8 rounded-sm flex items-center justify-center mr-3"> | ||
{organization.logo_url ? ( | ||
<img className="p-1" src={organization.logo_url} alt="" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the alt could be organization logo
</div> | ||
) | ||
|
||
const menus = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to type this variable so we can have autocomplete and checked type?
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What does this PR do?
> Link to the JIRA ticket
PR Checklist
Global
Store
NX
feature
,ui
,data
,utils
Clean Code