Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jobs): environments variables #422

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Dec 13, 2022

What does this PR do?

  • Fix environments variables for Jobs and Container
  • Fix row deployments for Database

PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - fix(jobs): environments variables - 2022-12-13T14:42:52Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Dec 13, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit aa9df91. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@RemiBonnet RemiBonnet marked this pull request as ready for review December 13, 2022 16:53
@codecov-commenter
Copy link

Codecov Report

Merging #422 (aa9df91) into staging (b4f8e29) will decrease coverage by 0.19%.
The diff coverage is 28.57%.

@@             Coverage Diff             @@
##           staging     #422      +/-   ##
===========================================
- Coverage    53.41%   53.22%   -0.20%     
===========================================
  Files          300      300              
  Lines         5629     5653      +24     
  Branches      1192     1206      +14     
===========================================
+ Hits          3007     3009       +2     
- Misses        2238     2255      +17     
- Partials       384      389       +5     
Impacted Files Coverage Δ
...able/src/lib/slices/environment-variables.slice.ts 55.69% <0.00%> (-2.20%) ⬇️
...eature/crud-environment-variable-modal-feature.tsx 52.94% <ø> (ø)
...ture/import-environment-variable-modal-feature.tsx 84.84% <ø> (ø)
...variable-modal/crud-environment-variable-modal.tsx 100.00% <ø> (ø)
...riable-modal/import-environment-variable-modal.tsx 84.21% <ø> (ø)
...c/lib/slices/secret-environment-variables.slice.ts 23.18% <9.09%> (-1.23%) ⬇️
...s/compute-available-environment-variable-scope.tsx 66.66% <50.00%> (-19.05%) ⬇️
...onment-variable-modal-feature/utils/form-check.tsx 100.00% <100.00%> (ø)
libs/pages/logs/deployment/src/lib/ui/row/row.tsx 92.85% <0.00%> (-3.30%) ⬇️
libs/shared/utils/src/lib/tools/date.tsx 23.07% <0.00%> (-0.93%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bdebon bdebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good !

@RemiBonnet RemiBonnet merged commit dc3ecd4 into staging Dec 14, 2022
@RemiBonnet RemiBonnet deleted the fix/jobs-environment-variables branch December 14, 2022 08:44
@bdebon
Copy link
Contributor

bdebon commented Dec 21, 2022

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants