Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support + operator for adding items to the ImmutableCollection #38

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

Corniel
Copy link
Contributor

@Corniel Corniel commented Jun 7, 2023

Syntactic sugar that should allow things like:

var events = ImmutableCollection.Empty;
events += SomeCondtion ? new SomeEvent() : new SomeOtherEvent();

@Corniel Corniel self-assigned this Jun 7, 2023
@Corniel Corniel requested a review from Sjaaky June 7, 2023 07:49
@CptWesley
Copy link

Approved. There are some github action warnings though.

@Corniel
Copy link
Contributor Author

Corniel commented Jun 7, 2023

@CptWesley I do not see a check?

@CptWesley
Copy link

image

@Corniel
Copy link
Contributor Author

Corniel commented Jun 7, 2023

@CptWesley I was referring to your approval. The actions issue I'll look into.

Copy link

@Sjaaky Sjaaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@Sjaaky Sjaaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Corniel Corniel merged commit d1d6e4a into master Jun 7, 2023
1 check passed
@Corniel Corniel deleted the addition-operator branch June 7, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants