test system with docker executor && tagged demo 2 #13
Conversation
demo2/reciever_python/Parser.py
Outdated
| if insert_data: | ||
| return insert_data, Tag_to_add, tags | ||
| return None, None, None | ||
|
|
There was a problem hiding this comment.
Please, run pylint and black on all python files.
demo2/reciever_python/Parser.py
Outdated
| tags - tags for insert query | ||
| """ | ||
|
|
||
| if isinstance(data) != str: |
There was a problem hiding this comment.
this is not a valid python code
| @@ -0,0 +1 @@ | |||
| *.cgroups.*.cpu.* host.measurement.cgroup.measurement.field | |||
There was a problem hiding this comment.
could you please add more templates?
There was a problem hiding this comment.
I mean like 10 more or even 100. You can use the ones I provided in matrix chat
| @@ -0,0 +1 @@ | |||
| *.cgroups.*.cpu.* host.measurement.cgroup.measurement.field | |||
There was a problem hiding this comment.
I mean like 10 more or even 100. You can use the ones I provided in matrix chat
|
|
||
| demo0: | ||
| jobs: | ||
| - build_demo_0 |
| #!/bin/sh | ||
|
|
||
| key=$(<../demo2/grafana-key/key.txt) | ||
| req='/d-solo/JE7rYbjmz/dh?orgId=1&panelId=2&width=1000&height=500' |
There was a problem hiding this comment.
is this always going to be JE7rYbjmz?
| key=$(<../demo2/grafana-key/key.txt) | ||
| req='/d-solo/JE7rYbjmz/dh?orgId=1&panelId=2&width=1000&height=500' | ||
| curl 'http://localhost:3000/render'$req \ | ||
| -H 'Authorization: Bearer '$key \ |
There was a problem hiding this comment.
please use the full argument name and add indentation for readability
There was a problem hiding this comment.
e.g. --header instead of -H
| dockerize -wait tcp://localhost:${PORT} -timeout 2m | ||
| for (( i=1; i <= 10; i++ )) do | ||
| R=$((RANDOM % 100)) | ||
| echo my.awesome.path $R `date +%s` | nc ${SERVER} ${PORT} -w 1 |
There was a problem hiding this comment.
so if I understand correctly this is the only place where graphite strings are generated currently but this is the only place where they all fall under the same pattern (*)
| @@ -0,0 +1,2 @@ | |||
| *.cgroups.*.cpu.* host.measurement.cgroup.measurement.field | |||
| *.*.path.* | |||
There was a problem hiding this comment.
and this pattern (*) isn't mentioned here
with docker executor in circleci env is specified with - setup_remote_docker (otherwise it can not build images) so i can't use dockerise