adding test config #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-of-kpp
suggested changes
Mar 23, 2019
.circleci/config.yml
Outdated
| docker stop stand_grafana_1 | ||
| docker stop stand_carbon-clickhouse_1 | ||
| docker stop stand_clickhouse_1 | ||
|
|
There was a problem hiding this comment.
please add produced image as an Artifact.
.circleci/config.yml
Outdated
| - checkout | ||
| - run: | | ||
| cd stand | ||
| (docker-compose up)& |
There was a problem hiding this comment.
it is probably better to run this in executor, maybe ignoring docker-compose - just manually call docker
.circleci/config.yml
Outdated
| (docker-compose up)& | ||
| sleep 180 | ||
| (timeout 30 bash generator.sh)& | ||
| sleep 20 |
There was a problem hiding this comment.
with circle ci you can dockerize -wait tcp:// to avoid sleeps
.circleci/config.yml
Outdated
| sleep 180 | ||
| (timeout 30 bash generator.sh)& | ||
| sleep 20 | ||
| bash image.sh |
There was a problem hiding this comment.
you can use run instruction multiple times for better output structure
.circleci/config.yml
Outdated
| sleep 30 | ||
| docker stop stand_grafana_1 | ||
| docker stop stand_carbon-clickhouse_1 | ||
| docker stop stand_clickhouse_1 |
There was a problem hiding this comment.
you will not need stops once you define services
code-of-kpp
suggested changes
Apr 25, 2019
|
|
||
| - run: | ||
| name: install dockerize | ||
| command: wget https://github.com/jwilder/dockerize/releases/download/$DOCKERIZE_VERSION/dockerize-linux-amd64-$DOCKERIZE_VERSION.tar.gz && sudo tar -C /usr/local/bin -xzvf dockerize-linux-amd64-$DOCKERIZE_VERSION.tar.gz && rm dockerize-linux-amd64-$DOCKERIZE_VERSION.tar.gz |
There was a problem hiding this comment.
Could you please split that line?
Also dockerize should be present in circleci native images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI config (#2)
runs correctly (seems so), but current master code fails