Fix minimum CMake version requirement #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess various problems slipped in during #112 that upped the minimum CMake version from 2.8.11 all the way to 3.12. This has to do with object libraries linking to other object libraries. The object libraries are needed at all for pre-#105 build-system compatibility (the old build system would produce both a static and shared library for libqasm, which cannot be done with normal libraries), and until 3.12, object libraries did not support transitive dependency resolution.
I'm not sure it's worth spending more on ancient CMake version compatibility than the half a day I wasted on this already, as installing a newer CMake than your package manager supports is pretty easy (CMake provides its own binary builds for all platforms). If someone does have a problem with this at some point please open an issue and state which minimum version I'd have to target.