[SDS-301] Fix for damaged projects and not enough classical bits #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
QFer
commented
Jun 3, 2021
•
QFer
commented
- Adjusted readthedocs for using version 3.8 of python
- Fix for damaged projects when error occured while post-processing the cQASM algorithm
- Check added during pre-processing for experiments where the number of classical bits is not enough to hold the measured qubits
- Removed format_vector method not used in notebook
- Renamed IPython to Jupyter
peendebak
reviewed
Jun 9, 2021
| number_of_classical_bits = measurements['number_of_clbits'] | ||
| max_measurement_index = max(measurement[1] for measurement in measurements['measurements']) | ||
| if max_measurement_index >= number_of_classical_bits: | ||
| raise QisKitBackendError("Number of classical bits is not sufficient for storing the outcomes of the" |
There was a problem hiding this comment.
Suggested change
| raise QisKitBackendError("Number of classical bits is not sufficient for storing the outcomes of the" | |
| raise QisKitBackendError(f"Number of classical bits {number_of_classical_bits} is not sufficient for storing the outcomes of the" |
| api.execute_qasm_async.return_value = quantum_inspire_job | ||
| api.get_backend_type_by_name.return_value = {'max_number_of_shots': 4096} | ||
| simulator = QuantumInspireBackend(api, Mock()) | ||
| instructions = [{'name': 'h', 'qubits': [0]}, |
There was a problem hiding this comment.
Are all these instructions needed? This is internal qiskit format and prone to change. Could you not write this test by letting qiskit generarate similar data? E.g.
c=QuantumCircuit(3,3)
c.h(0)
c.h(2)
c.measure_all()
...
There was a problem hiding this comment.
All these instructions are not necessary, I copied them from another test. Actually a measurement is enough, I changed that.
You are right that this is qiskit format but the easiest way to create sometimes specific instructions for the various test cases. For some test cases this is actually not needed, I added a ticket (SDS-371) to the SDK backlog to investigate this suggestion.
peendebak
approved these changes
Jun 11, 2021
This was referenced Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.