[SDS-307] Now able to get calibration data from result #103
Conversation
QFer
commented
Jun 3, 2021
QFer
commented
- Added method to get calibration info to api
- Added unit tests
src/quantuminspire/api.py
Outdated
| @@ -676,6 +676,32 @@ def get_measurement_register_from_result(self, result_id: int) -> List[Any]: | |||
| raise ApiError(f'Measurement register for result with id {result_id} does not exist!') from err_msg | |||
| return measurement_register | |||
|
|
|||
| def get_calibration_from_result(self, result_id: int) -> Optional[Any]: | |||
| """ Gets the calibration information of the executed cQASM code, given the result_id. | |||
There was a problem hiding this comment.
| """ Gets the calibration information of the executed cQASM code, given the result_id. | |
| """ Gets the calibration information of the executed code, given the result_id. |
We also submit qiskit code (right that that is converted to cqasm internally, but that might change)
There was a problem hiding this comment.
Changed it to executed job. Also changed some other instances of cQASM (where it is not needed to be called cQASM explicitly)
| result = self.get_result(result_id) | ||
| calibration_url = result.get('calibration') | ||
| if calibration_url is not None: | ||
| try: |
There was a problem hiding this comment.
I guess this code works, but is the parsing of the url needed? One can just do
result = requests.get(c, auth=authentication)
calibration = result.json()
(the authentication and .json can be wrapped in something off course)
There was a problem hiding this comment.
Yes, you can directly use request package to send a get for this url,, but I think it is better to use the already authenticated coreapi consistently for all communication with the backend api as it is now done in SDK.
QFer
force-pushed
the
fix/sds-307/calibration-info
branch
from
31f8983
to
5228be3
Compare
|
Had to force push after rebase |
