Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDS-423] Coupling map qiskit #109

Merged
merged 3 commits into from
Aug 31, 2021
Merged

[SDS-423] Coupling map qiskit #109

merged 3 commits into from
Aug 31, 2021

Conversation

QFer
Copy link
Contributor

@QFer QFer commented Aug 23, 2021

  • Fixed coupling map type
  • Added queue_position method to job for queued jobs
  • Calculate total time taken for all jobs in result

@coveralls
Copy link
Collaborator

coveralls commented Aug 23, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 22faa42 on fix/sds-423/coupling_map_qiskit into 88ad921 on dev.

@QFer QFer mentioned this pull request Aug 23, 2021
Closed
@QFer QFer linked an issue Aug 23, 2021 that may be closed by this pull request
Qiskit SDK fails for Starmon-5 #107
Closed
@QFer QFer requested a review from eendebakpt August 23, 2021 15:38
codecrap
codecrap approved these changes Aug 24, 2021
View reviewed changes
Copy link

@codecrap codecrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code and ran it against the minimal example in issue #107, and I do not get the error anymore so the issue seems solved. @peendebak

@QFer QFer merged commit de217f6 into dev Aug 31, 2021
@QFer QFer deleted the fix/sds-423/coupling_map_qiskit branch August 31, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eendebakpt eendebakpt eendebakpt approved these changes

@codecrap codecrap codecrap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Qiskit SDK fails for Starmon-5
4 participants
@QFer @coveralls @eendebakpt @codecrap