Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEM-1440] ipython notebook change deprecated method #80

Merged
merged 1 commit into from
May 3, 2020

Conversation

QFer
Copy link
Contributor

@QFer QFer commented Apr 22, 2020

  • Deprecated method renamed iden() to use i() - Qiskits equivalent method

@coveralls
Copy link
Collaborator

coveralls commented Apr 22, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling a3cfcbc on fix/dem-1440/deprecated_qiskit_method into dbf7cde on dev.

@amit1rrr
Copy link

Sorry to intrude but I noticed this PR contains Jupyter notebook files that are hard to review on GitHub due to the JSON diffs.

You might want to checkout ReviewNB, code review tool for notebooks. Provides visual diffs & commenting for Jupyter notebooks on GitHub. Completely free for open source repositories.

Disclaimer: I built ReviewNB

diff_and_commenting

rhjdjong
rhjdjong previously approved these changes Apr 29, 2020
Copy link
Contributor

@bogdanvconstantin bogdanvconstantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 runs fine :) ; looks good!

@QFer QFer removed the request for review from rhjdjong May 3, 2020 13:36
@QFer QFer merged commit 8e79f8b into dev May 3, 2020
@QFer QFer deleted the fix/dem-1440/deprecated_qiskit_method branch September 6, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants