Fix out of sync creation of NetQASM LAST log #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkreynen
force-pushed
the
fix/netqasm-last-log
branch
2 times, most recently
from
30106b7
to
ea8c733
Compare
|
Not entirely sure why this pipeline is failing. I tested with a PR with 0 changes as well and the pipeline still failed |
bvdvecht
previously approved these changes
Jul 12, 2023
bvdvecht
dismissed
their stale review
Approved but then saw the examples pipeline failed.
|
It looks like the issue with the example pipeline is related to the |
|
Thanks @bvdvecht I pushed a fix |
bvdvecht
approved these changes
Jul 13, 2023
|
Thanks @bkreynen ! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on QNE we found an issue in NetQASM/SquidASM (the issue is on the NetQASM repo QuTech-Delft/netqasm#55 ).
In short: the log files were being processed in both NetQASM and SquidASM due to which it happened out of order. To fix this a change was made to NetQASM (see PR: QuTech-Delft/netqasm#56 for a detailed explanation) where the log files are now copied in NetQASM instead. Although these changes in SquidASM are not strictly required (NetQASM will just overwrite the log files SquidASM puts in LAST). For cleanliness I removed the calls in SquidASM.