Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic support for GUILD_MEDIA channels. #109

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnotherZane
Copy link
Collaborator

Description

Start implementation of GUILD_MEDIA channels (16).
Ref: New GUILD_MEDIA channel type, Media Channels

Checklist

  • I discussed this PR with the maintainer(s) prior to opening it.
  • I read the contributing guidelines.
  • I tested the changes in this PR.

@AnotherZane
Copy link
Collaborator Author

AnotherZane commented Dec 21, 2023

Need opinions on renaming IForumChannel. I considered using IThreadOnlyChannel but that would lead to awkward naming for some classes such as CreateForumThreadJsonRestRequestContent.

Also need to consider if IForumChannel should still exist, however as a new entity (inheriting its renamed version) since the default_forum_layout property currently exists on media channels (in the API) but is only used in forums channels (as per documentation).

Perhaps we refactor to IMediaChannel which can be inherited by IForumChannel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant