Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Update cibuildwheels version to fix Windows wheel building #171

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

TomWinder
Copy link
Member

What is the purpose of this Pull Request?

Bump of cibuildwheel version to fix #170 -- cibuildwheel 2.12.0 -> 2.16.5

As per pypa/cibuildwheel#1740

Relevant Issues

#170

Test cases

Please detail any tests that you have used to ensure your changes do not introduce bugs.

  • All examples run without any new warnings
  • test_benchmarks.py reports all example tests pass

System details

(Tested on ubuntu 22.04; but really needs to run actions workflow to test)

Final checklist

  • Correct base branch selected?
    • master (if a bugfix/patch update)
    • version/vX.X.X if a new significant feature (discuss with developers)
  • All tests still pass.

@TomWinder
Copy link
Member Author

(Build seems to run fine just fine)

@hemmelig
Copy link
Member

Never ending, isn't it...

Copy link
Member

@hemmelig hemmelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto.

@hemmelig hemmelig merged commit 5154e44 into master Feb 18, 2024
20 checks passed
@hemmelig hemmelig deleted the fix/cibuildwheel branch February 18, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: cibuildwheel fails to build wheels for Windows
2 participants