Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Web Service to know the status of the last task on Compute Engine #47

Merged
merged 2 commits into from
Nov 9, 2016

Conversation

apieraf
Copy link
Contributor

@apieraf apieraf commented Sep 13, 2016

We have developed a new web service to create a badge with the status of the last task of a project

@pawlakm
Copy link
Member

pawlakm commented Oct 25, 2016

Thanks for the contribution. I'll review it ASAP.

@pawlakm pawlakm merged commit bc64580 into QualInsight:master Nov 9, 2016
@pawlakm
Copy link
Member

pawlakm commented Nov 10, 2016

Thanks for your contribution, it adds a nice feature to the plugin.

Here are a few remarks to improve your future contributions:

  • There is a developer toolset page please read it and follow described guidelines (especially code formatting).
  • please create PRs from a repository clone and not from a fork: currently due to a Travis-CI (security) limitation, external (i.e. from a fork) PRs cannot be analyzed using SonarQube.
  • do not hesitate to contact me if you see that the plugin's code could be refactored to better suit your needs. Indeed, as you based your contribution on the code of existing WS, this ended up with code duplication, I could have (and will do it as a next step) refactored it in order to factorize code and minimise code duplication which would have in turn minimised your development effort.

Kind regards,

Michel

@pawlakm pawlakm added this to the 2.1.0 milestone Nov 10, 2016
@pawlakm pawlakm self-assigned this Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants