Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBI 179924 - Support token authentication for github private repos in app configuration management #97

Merged
merged 4 commits into from
Mar 17, 2021
Merged

PBI 179924 - Support token authentication for github private repos in app configuration management #97

merged 4 commits into from
Mar 17, 2021

Conversation

AdamSharon
Copy link
Contributor

Adding logic to handle Token \ Credentials
Adding Tests
Changing version to 1.6
changing requirements of driver to get the new version

@coveralls
Copy link

coveralls commented Mar 16, 2021 •
edited

Coverage Status

Coverage decreased (-0.8%) to 84.554% when pulling 055d668 on wip/adam.s/add_token_179924 into 318adf2 on develop.

nahumtimerman
nahumtimerman approved these changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@nahumtimerman nahumtimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AdamSharon AdamSharon merged commit b73a22a into develop Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahumtimerman nahumtimerman nahumtimerman approved these changes

@reubinoff reubinoff Awaiting requested review from reubinoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AdamSharon @coveralls @nahumtimerman