#75 - Added more unit tests for algorithm verification

QualiSystems · Feb 23, 2017 · 304a3f1 · 304a3f1
1 parent aa9f5df
commit 304a3f1
Showing 1 changed file with 32 additions and 1 deletion.
diff --git a/..._cp/test_openstack/test_domain/test_services/test_neutron/test_neutron_network_service.py b/..._cp/test_openstack/test_domain/test_services/test_neutron/test_neutron_network_service.py
@@ -70,6 +70,37 @@ def test_get_network_with_segmentation_id_no_network(self):
                                                                        logger=self.mock_logger)
         self.assertEqual(result, None)
 
+    def test_valid_cidr_returned(self):
+
+        mock_client = Mock()
+        test_neutron_network_service.neutron_client.Client = Mock(return_value=mock_client)
+        mock_client.create_subnet = Mock(return_value={'subnet': 'subnet success'})
+
+        mock_return_subnets = {'subnets': [{'cidr': '10.0.0.0/24', 'id': 'test-id-1'},
+                                           {'cidr': '10.0.1.0/24', 'id': 'test-id-2'}]}
+
+        test_reserved_subnets = '172.0.0.0/8, 192.168.0.0/24'
+        mock_client.list_subnets = Mock(return_value=mock_return_subnets)
+        result = self.network_service._get_unused_cidr(client=mock_client,
+                                                       cp_resvd_cidrs=test_reserved_subnets,
+                                                       logger=self.mock_logger)
+        self.assertEqual(result, '10.0.2.0/24')
+
+    def none_cidr_returned(self):
+        mock_client = Mock()
+        test_neutron_network_service.neutron_client.Client = Mock(return_value=mock_client)
+        mock_client.create_subnet = Mock(return_value={'subnet': 'subnet success'})
+
+        mock_return_subnets = {'subnets': [{'cidr': '10.0.0.0/24', 'id': 'test-id-1'},
+                                           {'cidr': '10.0.1.0/24', 'id': 'test-id-2'}]}
+
+        test_reserved_subnets = '10.0.0.0/8, 172.16.0.0/12 , 192.168.0.0/24'
+        mock_client.list_subnets = Mock(return_value=mock_return_subnets)
+        result = self.network_service._get_unused_cidr(client=mock_client,
+                                                       cp_resvd_cidrs=test_reserved_subnets,
+                                                       logger=self.mock_logger)
+        self.assertEqual(result, None)
+
     def test_create_and_attach_subnet_to_net_success(self):
 
         test_net_id = 'test-net-id'
@@ -80,7 +111,7 @@ def test_create_and_attach_subnet_to_net_success(self):
         mock_return_subnets = {'subnets':[{'cidr': '192.168.1.0/24', 'id':'test-id-1'},
                                {'cidr': '192.168.1.0/24', 'id': 'test-id-2'}]}
 
-        test_reserved_subnets = '10.0.0.0/16, 172.16.0.0/12, 192.168.0.0/24'
+        test_reserved_subnets = '10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/24'
         mock_client.list_subnets = Mock(return_value=mock_return_subnets)
 
         cp_resource_model = Mock()