Merge pull request #13 from QualiSystems/feature/borismod_context2

remove context from ctor of ErrorHandlingContext

cloudshell/core/context/context_service.py

@@ -2,10 +2,6 @@
 
 
 class ContextBasedService(object):
-    @abstractmethod
-    def get_objects(self):
-        pass
-
     @abstractmethod
     def context_started(self):
         pass
@@ -15,7 +11,7 @@ def context_ended(self, exc_type, exc_val, exc_tb):
         pass
 
     def __enter__(self):
-        self.context_started()
+        return self.context_started()
 
     def __exit__(self, exc_type, exc_val, exc_tb):
         self.context_ended(exc_type, exc_val, exc_tb)

cloudshell/core/context/error_handling_context.py

@@ -4,15 +4,13 @@
 
 
 class ErrorHandlingContext(ContextBasedService):
-    def __init__(self, context, logger):
+    def __init__(self, logger):
         """
         Initializes an instance of ErrorHandlingContext
         Allows proper logging on exception
-        :param context: ResourceCommandContext
         :param logger: Logger
         :type logger: Logger
         """
-        self.context = context
         self.logger = logger
 
     def get_objects(self):

tests/core/context/test_error_handling_context.py

@@ -8,11 +8,10 @@
 class TestLoggingSession(TestCase):
 
     def test_log_written_when_exception_occurs(self):
-        context = Mock()
         logger = Mock()
         logger.error = MagicMock()
         try:
-            with ErrorHandlingContext(context=context, logger=logger):
+            with ErrorHandlingContext(logger=logger):
                 raise ValueError('some value error occurred')
         except ValueError:
             self.assertTrue(logger.error.called)