Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for incorrect link assembling + tests, fixes #43 #44

Merged
merged 6 commits into from
Nov 7, 2018
Merged

fix for incorrect link assembling + tests, fixes #43 #44

merged 6 commits into from
Nov 7, 2018

Conversation

Costya-Y
Copy link
Collaborator

@Costya-Y Costya-Y commented Nov 2, 2018 •
edited by yaroslavNqualisystems

This change is Reviewable

@coveralls
Copy link

coveralls commented Nov 2, 2018 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling bbce761 on save_restore_path_fix into 3088aa7 on dev.

@Costya-Y Costya-Y closed this Nov 2, 2018
@Costya-Y Costya-Y reopened this Nov 2, 2018
@Costya-Y Costya-Y changed the title fix for incorrect link assembling + tests fix for incorrect link assembling + tests, fixes #43 Nov 7, 2018
saklar13
saklar13 approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@saklar13 saklar13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alexquali)

alexquali
alexquali approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@alexquali alexquali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Costya-Y Costya-Y merged commit 9eaa798 into dev Nov 7, 2018
@Costya-Y Costya-Y deleted the save_restore_path_fix branch November 7, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saklar13 saklar13 saklar13 approved these changes

@alexquali alexquali alexquali approved these changes

Assignees

@saklar13 saklar13

@alexquali alexquali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Costya-Y @coveralls @saklar13 @alexquali