Add regression tests

[ayeleta]

Regression tests + unit tests of the Sandbox class

---

This change is 

[kalsky]

Review status: 0 of 17 files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 207 at r1 (raw file):

        self.sandbox.clear_all_resources_live_status()
        self.mock_api_session.return_value.SetResourceLiveStatus.assert_called()

check that the api was called twice

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 225 at r1 (raw file):

        self.sandbox.clear_all_resources_live_status()
        self.mock_api_session.return_value.SetResourceLiveStatus.assert_called()

1. add assert not called for services
2. check that set live status api called twice

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 292 at r1 (raw file):

        self.mock_api_session.return_value.GetReservationDetails = Mock(return_value=rdi)
        self.sandbox.activate_connectors(True)
        self.mock_api_session.return_value.ConnectRoutesInReservation.assert_called()

check that this api was called with the second connector (connectionfailed)

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 349 at r1 (raw file):

    #================================================================
    #test activate_routes

update the comment

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 386 at r1 (raw file):

        self.sandbox.get_root_resources = Mock(return_value=rr)
        self.sandbox.power_on_vms()
        self.mock_api_session.return_value.ExecuteResourceConnectedCommand.assert_called_with('5487c6ce-d0b3-43e9-8ee7-e27af8406905', 'r2', 'PowerOn', 'power')

should be r1

---

Comments from Reviewable

[kalsky]

Reviewed 16 of 19 files at r1, 1 of 3 files at r2.
Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

---

Comments from Reviewable

[coveralls]

Coverage increased (+28.5%) to 28.477% when pulling e7dd887 on add_regression_tests into ba20695 on develop.

[kalsky]

Reviewed 3 of 3 files at r4.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

---

Comments from Reviewable

[kalsky]

Review status: all files reviewed at latest revision, 5 unresolved discussions.

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 207 at r1 (raw file):

Previously, kalsky wrote…

check that the api was called twice

OK

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 225 at r1 (raw file):

Previously, kalsky wrote…

1. add assert not called for services
2. check that set live status api called twice

function actually removed. OK

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 292 at r1 (raw file):

Previously, kalsky wrote…

check that this api was called with the second connector (connectionfailed)

OK

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 349 at r1 (raw file):

Previously, kalsky wrote…

update the comment

OK

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 386 at r1 (raw file):

Previously, kalsky wrote…

should be r1

OK

---

Comments from Reviewable

[kalsky]

OK

---

Review status: all files reviewed at latest revision, 5 unresolved discussions.

---

Comments from Reviewable

[kalsky]

Review status: all files reviewed at latest revision, 5 unresolved discussions.

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 225 at r1 (raw file):

Previously, kalsky wrote…

function actually removed. OK

OK

---

Comments from Reviewable

[kalsky]

LGTM

---

Comments from Reviewable

[ayeleta]

Review status: all files reviewed at latest revision, 5 unresolved discussions.

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 207 at r1 (raw file):

Previously, kalsky wrote…

OK

OK

---

Comments from Reviewable

[ayeleta]

Review status: all files reviewed at latest revision, 4 unresolved discussions.

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 225 at r1 (raw file):

Previously, kalsky wrote…

OK

OK

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 292 at r1 (raw file):

Previously, kalsky wrote…

OK

OK

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 349 at r1 (raw file):

Previously, kalsky wrote…

OK

OK

---

sandbox_scripts/QualiEnvironmentUtils/tests/test_Sandbox.py, line 386 at r1 (raw file):

Previously, kalsky wrote…

OK

OK

---

Comments from Reviewable