Refactor savenrestore gitlab #21

jimbr70 · 2017-04-19T18:31:29Z

changes to gitlab client, some messaging, various fixzes from merge.

This change is

add gitlab additional template support

…re' into refactor-saveNrestore-GITLAB # Conflicts: # sandbox_scripts/environment/setup/setup_resources.py # sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py

kalsky · 2017-04-19T21:26:18Z

Review status: 0 of 10 files reviewed at latest revision, 10 unresolved discussions, some commit checks failed.

sandbox_scripts/environment/setup/setup_resources.py, line 10 at r1 (raw file):

import os, sys

please remove these lines from the setup_resources file, you can add them in a test file that later will call/use this class.
this is also affecting the tests we're running.

also in the os.environ line you just override the value you got from cloudshell in a real execution so it needs to be removed from this file anyway.

sandbox_scripts/environment/setup/setup_resources.py, line 77 at r1 (raw file):

            self.logger.error("Setup failed. Unexpected error:" + str(sys.exc_info()[0]))

please remove these lines from the setup_resources file, you can add them in a test file that later will call/use this class.

sandbox_scripts/environment/teardown/teardown_resources.py, line 26 at r1 (raw file):

            if saveNRestoreTool.get_storage_manager():
                ignore_models = ['Generic TFTP server', 'Config Set Pool', 'Generic FTP server', 'netscout switch 3912',
                             'OnPATH Switch 3903', 'Ixia Traffic generator', "SubNet-28", "SubNet-30"]

are you missing the gitlab model here?

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 131 at r1 (raw file):

                if command.Name == 'restore':
                    for parm in command.Parameters:
                        print "****" + parm.Name + "****"

this print might appear in the output, we should remove it

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 132 at r1 (raw file):

                    for parm in command.Parameters:
                        print "****" + parm.Name + "****"
                        if parm.Name in "path, src_Path, xx123":

no need for the xx123 i guess (same as yy123, zzz123 below)
also, you're just checking if the param name is inside this string, not inside a list of values like this:
a = ["aaa","bbb","ccc"]
if "bbb" in a:

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 140 at r1 (raw file):

            if the_path == "undef" or the_cfgtype == "undef" or the_restoremeth == "undef":
                raise "Failed to find viable restore command for " + self.name \

why not raising a QualiError?

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 144 at r1 (raw file):

        except:
            raise "Failed building restore command input parm names."

why not raising a QualiError?

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 150 at r1 (raw file):

                              InputNameValue(the_cfgtype, str(config_type)),
                              InputNameValue(the_restoremeth, str(restore_method))]
            print "resource.py L124 " + self.name + "  configuration_type = " + str(config_type)

remove any (debug) prints, they might appear in the output

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 162 at r1 (raw file):

        except QualiError as qerror:
            print "ERROR1: Load config file failed. " + qerror.message

remove (debug) prints

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 167 at r1 (raw file):

        except:
            print "ERROR2: Load config file failed. "

remove (debug) prints

Comments from Reviewable

Run interactive setup from DebugInteractive_setup_resources.py under tests.

jimbr70 · 2017-04-20T17:22:22Z

sandbox_scripts/environment/setup/setup_resources.py, line 10 at r1 (raw file):

Previously, kalsky wrote…

please remove these lines from the setup_resources file, you can add them in a test file that later will call/use this class.
this is also affecting the tests we're running.

also in the os.environ line you just override the value you got from cloudshell in a real execution so it needs to be removed from this file anyway.

change made

Comments from Reviewable

kalsky · 2017-04-20T17:22:43Z

sandbox_scripts/environment/setup/setup_resources.py, line 10 at r1 (raw file):

Previously, kalsky wrote…

please remove these lines from the setup_resources file, you can add them in a test file that later will call/use this class.
this is also affecting the tests we're running.

also in the os.environ line you just override the value you got from cloudshell in a real execution so it needs to be removed from this file anyway.

OK

Comments from Reviewable

kalsky · 2017-04-20T17:23:22Z

sandbox_scripts/environment/setup/setup_resources.py, line 77 at r1 (raw file):

Previously, kalsky wrote…

please remove these lines from the setup_resources file, you can add them in a test file that later will call/use this class.

OK

Comments from Reviewable

jimbr70 · 2017-04-20T17:23:49Z

sandbox_scripts/environment/teardown/teardown_resources.py, line 26 at r1 (raw file):

Previously, kalsky wrote…

are you missing the gitlab model here?

Done. change made

Comments from Reviewable

jimbr70 · 2017-04-20T17:23:58Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 131 at r1 (raw file):

Previously, kalsky wrote…

this print might appear in the output, we should remove it

Done.

Comments from Reviewable

jimbr70 · 2017-04-20T17:24:43Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 132 at r1 (raw file):

Previously, kalsky wrote…

no need for the xx123 i guess (same as yy123, zzz123 below)
also, you're just checking if the param name is inside this string, not inside a list of values like this:
a = ["aaa","bbb","ccc"]
if "bbb" in a:

Done.

Comments from Reviewable

jimbr70 · 2017-04-20T17:24:49Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 140 at r1 (raw file):

Previously, kalsky wrote…

why not raising a QualiError?

Done.

Comments from Reviewable

jimbr70 · 2017-04-20T17:25:14Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 144 at r1 (raw file):

Previously, kalsky wrote…

why not raising a QualiError?

Done.

Comments from Reviewable

jimbr70 · 2017-04-20T17:25:22Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 150 at r1 (raw file):

Previously, kalsky wrote…

remove any (debug) prints, they might appear in the output

Done.

Comments from Reviewable

kalsky · 2017-04-20T17:25:28Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 132 at r1 (raw file):

Previously, jimbr70 wrote…

Done.

can't see it that it's done

Comments from Reviewable

jimbr70 · 2017-04-20T17:25:37Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 162 at r1 (raw file):

Previously, kalsky wrote…

remove (debug) prints

Done.

Comments from Reviewable

jimbr70 · 2017-04-20T17:25:51Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 167 at r1 (raw file):

Previously, kalsky wrote…

remove (debug) prints

Done.

Comments from Reviewable

jimbr70 · 2017-04-20T17:27:55Z

Review status: 0 of 12 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

sandbox_scripts/environment/setup/setup_resources.py, line 10 at r1 (raw file):

Previously, jimbr70 wrote…

change made

Done.

sandbox_scripts/environment/setup/setup_resources.py, line 77 at r1 (raw file):

Previously, kalsky wrote…

please remove these lines from the setup_resources file, you can add them in a test file that later will call/use this class.

Done.

Comments from Reviewable

kalsky · 2017-04-20T17:28:05Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 140 at r1 (raw file):

Previously, jimbr70 wrote…

Done.

can't see that it's done

Comments from Reviewable

jimbr70 · 2017-04-20T18:10:38Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 132 at r1 (raw file):

Previously, kalsky wrote…

can't see it that it's done

Done.

Comments from Reviewable

jimbr70 · 2017-04-20T18:10:54Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 140 at r1 (raw file):

Previously, kalsky wrote…

can't see that it's done

Done.

Comments from Reviewable

kalsky · 2017-04-20T18:12:13Z

Reviewed 4 of 10 files at r1, 6 of 8 files at r2, 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

coveralls · 2017-04-20T18:47:13Z

Coverage decreased (-1.03%) to 26.203% when pulling 70ccfd3 on refactor-saveNrestore-GITLAB into a07a839 on refactor_saveNrestore.

coveralls · 2017-04-20T19:11:34Z

Coverage decreased (-0.8%) to 26.413% when pulling 05d21fc on refactor-saveNrestore-GITLAB into a07a839 on refactor_saveNrestore.

coveralls · 2017-04-21T00:37:41Z

Coverage decreased (-0.8%) to 26.476% when pulling af92e24 on refactor-saveNrestore-GITLAB into a07a839 on refactor_saveNrestore.

kalsky · 2017-04-21T03:15:12Z

Reviewed 1 of 3 files at r4, 4 of 4 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

jimbr70 added 2 commits April 17, 2017 15:27

gitlab+template support

960ed34

add gitlab additional template support

Merge remote-tracking branch 'refs/remotes/origin/refactor_saveNresto…

75e42c8

…re' into refactor-saveNrestore-GITLAB # Conflicts: # sandbox_scripts/environment/setup/setup_resources.py # sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py

jimbr70 added 7 commits April 19, 2017 16:50

removed lines for interactive debug to a new file

5696670

Run interactive setup from DebugInteractive_setup_resources.py under tests.

edits per review

17a5a54

edits per review

bd6a92e

edits per review

4530adf

edits per review

0d7ef5a

edits per review

7afb293

edits per review

99b1401

jimbr70 added 5 commits April 20, 2017 10:56

edits per gitlab import

b293a27

edits per tftpy import

04267bb

edits of gitlab import

ae60263

added gitlab

1bf79b7

changed str to list

e6526c1

jimbr70 added 3 commits April 20, 2017 11:22

pip package is "python-gitlab"

85b5703

pip package is "python-gitlab"

8ed41b0

ignore models fixed.

70ccfd3

jimbr70 added 2 commits April 20, 2017 12:09

import change

1da0d20

import change

05d21fc

jimbr70 added 5 commits April 20, 2017 12:19

import change, again

22f7085

import change, again

1d85241

pyapi-gitlab is correct lib

7d23f4d

pyapi-gitlab is correct lib

9ed6c73

removed a print

af92e24

kalsky merged commit 4d16b5a into refactor_saveNrestore Apr 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor savenrestore gitlab #21

Refactor savenrestore gitlab #21

jimbr70 commented Apr 19, 2017 •

edited by AlonSaggie

Loading

kalsky commented Apr 19, 2017

jimbr70 commented Apr 20, 2017

kalsky commented Apr 20, 2017

kalsky commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

kalsky commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

kalsky commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

kalsky commented Apr 20, 2017

coveralls commented Apr 20, 2017

coveralls commented Apr 20, 2017

coveralls commented Apr 21, 2017

kalsky commented Apr 21, 2017

Refactor savenrestore gitlab #21

Refactor savenrestore gitlab #21

Conversation

jimbr70 commented Apr 19, 2017 • edited by AlonSaggie Loading

kalsky commented Apr 19, 2017

jimbr70 commented Apr 20, 2017

kalsky commented Apr 20, 2017

kalsky commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

kalsky commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

kalsky commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

jimbr70 commented Apr 20, 2017

kalsky commented Apr 20, 2017

coveralls commented Apr 20, 2017

coveralls commented Apr 20, 2017

coveralls commented Apr 21, 2017

kalsky commented Apr 21, 2017

jimbr70 commented Apr 19, 2017 •

edited by AlonSaggie

Loading