Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests #25

Merged
merged 16 commits into from
May 5, 2017
Merged

More tests #25

merged 16 commits into from
May 5, 2017

Conversation

kalsky
Copy link
Member

@kalsky kalsky commented Apr 28, 2017

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+11.9%) to 28.035% when pulling 7f421cc on more-tests into 7e16ec2 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+14.2%) to 30.317% when pulling fc53857 on more-tests into 7e16ec2 on develop.

# Conflicts:
#	sandbox_scripts/QualiEnvironmentUtils/Resource.py
#	sandbox_scripts/QualiEnvironmentUtils/Sandbox.py
#
sandbox_scripts/QualiEnvironmentUtils/tests/DebugInteractive_setup_resou
rces.py
#	sandbox_scripts/environment/setup/setup_VM.py
#	sandbox_scripts/environment/teardown/teardown_VM.py
#	sandbox_scripts/environment/teardown/teardown_resources.py
#	sandbox_scripts/helpers/Networking/NetworkingSaveNRestore.py
#	test_requirements.txt
@coveralls
Copy link

Coverage Status

Coverage increased (+13.7%) to 29.7% when pulling 31e0f75 on more-tests into 381c113 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.7%) to 29.7% when pulling 301cedd on more-tests into 381c113 on develop.

@kalsky
Copy link
Member Author

kalsky commented May 5, 2017

Reviewed 14 of 24 files at r1, 1 of 3 files at r2, 7 of 8 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@ayeleta
Copy link

ayeleta commented May 5, 2017

Reviewed 14 of 24 files at r1, 1 of 3 files at r2, 7 of 8 files at r3, 1 of 1 files at r4.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@kalsky kalsky merged commit a43d2ca into develop May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants